Open
Conversation
Merged
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (55.08%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #2 +/- ##
===========================================
+ Coverage 0 55.08% +55.08%
===========================================
Files 0 11 +11
Lines 0 403 +403
===========================================
+ Hits 0 222 +222
- Misses 0 180 +180
- Partials 0 1 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mengelbart
force-pushed
the
feat/gcc
branch
7 times, most recently
from
9d45de5 to
195285a
Compare
mengelbart
force-pushed
the
feat/gcc
branch
8 times, most recently
from
c05dd2f to
7d98306
Compare
mengelbart
force-pushed
the
feat/gcc
branch
4 times, most recently
from
d01e534 to
6fb5b52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a refactored version of the GCC implementation from pion/interceptor. It includes a simulation test that runs >100 simulations using vnet from pion/transport. Simulations are hidden behind a
simulationbuild tag, because they generate a lot of log files. The simulation package contains a simple python script to create plots for each of the simulation experiments. In a future PR, I plan to replace the GCC implementation in pion/interceptor with the one implemented here.To run the simulation, run
go test -v -tags=simulation ./simulation/. It will create a directorysimulation/logscontaining two log files for each run, one containing packet logs from the packet dumper interceptor and one containing pion logs. To create plots, run./main.pyfrom within the simulation directory. The plots will be placed in thelogsdirectory. Alternatively, you can pass input or output to the script manually, using the '-i', or '-o' flags.This PR should not be merged before pion/interceptor#374. When that PR is merged, the
go.modreference in this PR needs to be updated.